🔨♻️Performance testing: upgrade locust infrastructure #7711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
t:maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7711 +/- ##
===========================================
- Coverage 86.79% 64.41% -22.38%
===========================================
Files 1841 683 -1158
Lines 71507 32262 -39245
Branches 1215 174 -1041
===========================================
- Hits 62066 20783 -41283
- Misses 9099 11421 +2322
+ Partials 342 58 -284
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
new-locust-checks
branch
6 times, most recently
from
8a89c23 to
32e33a7
Compare
…in webserver services
sanderegg
force-pushed
the
new-locust-checks
branch
from
32e33a7 to
39de6e4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the performance testing framework by replacing Docker-based workflows with Python-based tools, enhancing credential/configuration management, and improving usability and documentation.
- Introduces new locust test files (e.g., single endpoint RPS tester) with updated authentication handling.
- Removes obsolete Docker-related files and configurations.
- Updates the Makefile and README to support interactive and CI-based testing, alongside Grafana integration.
Reviewed Changes
Copilot reviewed 30 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/performance/locustfiles/deployment_max_rps_single_endpoint.py | New locust test file utilizing interactive endpoint selection and authentication. |
| tests/performance/locust_settings.py | Removed obsolete settings file no longer needed with the updated workflow. |
| tests/performance/locust_files/webserver_services.py | Removed deprecated Docker-based webservice test file. |
| tests/performance/locust_files/user_basic_calls.py | Removed outdated test file for basic API calls. |
| tests/performance/locust_files/platform_ping_test.py | Removed redundant test file for platform ping functionality. |
| tests/performance/locust_files/locustfile.py | Removed generic locustfile now replaced by specialized test files. |
| tests/performance/locust_files/director_services.py | Removed legacy director services test file. |
| tests/performance/locust_files/catalog_services.py | Removed legacy catalog services test file. |
| tests/performance/common/base_user.py | Added new base user classes with enhanced authentication and logging support. |
| tests/performance/common/auth_settings.py | Introduced new authentication settings leveraging Pydantic’s configuration management. |
| tests/performance/README.md | Expanded documentation and updated Makefile target descriptions for clarity. |
Files not reviewed (6)
- scripts/common.Makefile: Language not supported
- tests/performance/.gitignore: Language not supported
- tests/performance/Dockerfile: Language not supported
- tests/performance/Makefile: Language not supported
- tests/performance/docker-compose.yml: Language not supported
- tests/performance/docker/Dockerfile: Language not supported
pcrespov
approved these changes
May 27, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
Thx! Greatly appreciated! Will start using it more.
|
Contributor
|
Very nice! Thanks a lot for the effort! Will start using immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request introduces significant updates to the performance testing framework for
osparc-simcore, focusing on modernization, simplification, and improved usability. Key changes include replacing Docker-based workflows with Python-based tools, adding robust credential and configuration management, and enhancing the Makefile and documentation for better developer and CI integration.Major Changes
0. Upgrade of locust version, simplification of usage, migration of locust files (simple RPS tester, webserver services tester, meta-modelling tests)
1. Makefile and Workflow Enhancements
tests/performance/Makefileto replace Docker-based workflows with Python-based tools, introducing new targets for deployment testing, credential management, and configuration file handling. Added interactive prompts for first-time setup and CI-specific modes.2. Credential and Configuration Management
.auth-credentials.envand.locust.conffiles for storing credentials and Locust configurations, with support for interactive prompts or CI pipelines. Updated.gitignoreto exclude these files.DeploymentAuthandOsparcAuthclasses inauth_settings.pyfor securely managing credentials using Pydantic.3. Codebase Simplification
Dockerfile,docker-compose.yml, and associated Makefile targets, to simplify the setup and reduce dependencies.4. Test Framework Enhancements
OsparcUserBaseandOsparcWebUserBaseclasses inbase_user.pyto provide reusable base classes for Locust users, supporting authenticated requests and optional login/logout functionality.5. Improved Documentation
README.mdwith detailed instructions on using the new Makefile targets, setting up credentials and configurations, and running tests interactively or in CI. Added examples for CI integration and Grafana visualization.Related issue/s
How to test
Dev-ops